Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4235 - Direct access-by-URL to sidebar curation mode sometimes does not work #4242

Conversation

reckart
Copy link
Member

@reckart reckart commented Oct 12, 2023

What's in the PR

  • Introduce a new event "PreparingToOpenDocumentEvent" which gives the curation sidebar the opportunity to set the data owner to the curation target before actually starting to load the document.
  • Improve debug/trace logging
  • Modernizing some terminologies and use var

How to test manually

Automatic testing

  • PR includes unit tests

Documentation

  • PR updates documentation

…not work

- Introduce a new event "PreparingToOpenDocumentEvent" which gives the curation sidebar the opportunity to set the data owner to the curation target before actually starting to load the document.
- Improve debug/trace logging
- Modernizing some terminologies and use var
@reckart reckart added this to the 29.6 milestone Oct 12, 2023
@reckart reckart self-assigned this Oct 12, 2023
…sidebar-curation-mode-sometimes-does-not-work
…not work

- More detailed trace logging related to curation sidebar and access control
…not work

- Move initialization of CurationSidebarBehaviour into a proper application initializer
- Improve pushing of page paraemeters into fragement parameters in AnnotationPageBase
…sidebar-curation-mode-sometimes-does-not-work

* release/29.x:
  #4259 - Opening a document viewing a specific annotator from the activities list does not work

% Conflicts:
%	inception/inception-api-annotation/src/main/java/de/tudarmstadt/ukp/clarin/webanno/api/annotation/page/AnnotationPageBase.java
%	inception/inception-ui-annotation/src/main/java/de/tudarmstadt/ukp/clarin/webanno/ui/annotation/AnnotationPage.java
@reckart reckart merged commit a71ae8e into release/29.x Oct 31, 2023
@reckart reckart deleted the bugfix/4235-Direct-access-by-URL-to-sidebar-curation-mode-sometimes-does-not-work branch October 31, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant